D15580: New annotation toolbar

[Andreas Hurka]

andreashurka added a comment.


  I've just tested this on manjaro-kde
  
  Operating System: Manjaro Linux 
  KDE Plasma Version: 5.17.1
  KDE Frameworks Version: 5.63.0
  Qt Version: 5.13.1
  
    git clone ...
    git apply D15580.diff
    mkdir build && cd build
    cmake ..
    make
    sudo make install
  
  and removed all config files.
  I've found five issues:
  
  - stamps won't get printed (both to pdf and paper)
  - when setting the opacity to something below 100% through the toolbar button Opacity it gets set to 0%
  - when creating lines ( arrow, straight line, polygon) painting artifacts appear. They disappear when confirming with left click but stay when aborting with right click.
  - very short and thick arrows look weirder than expected (same for short lines with opened arrow ends)
  
  F7703360: image.png <https://phabricator.kde.org/F7703360>
  
  - Zooming out while drawing a line makes the preview disappear but in exchange we get more artifacts.

REPOSITORY
  R223 Okular

BRANCH
  new-annotation-toolbar_ToggleActionMenu

REVISION DETAIL
  https://phabricator.kde.org/D15580

To: simgunz, #okular, #vdg, ngraham
Cc: andreashurka, yurchor, trickyricky26, simgunz, ltoscano, cfeck, aacid, davidhurka, knambiar, ngraham, tobiasdeiminger, okular-devel, johnzh, andisa, siddharthmanthan, maguirre, fbampaloukas, joaonetto, kezik, tfella, darcyshen
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20191031/33555e6d/attachment.html>