D24696: don't crash on nullptr pdfOptionsPage
Harald Sitter
noreply at phabricator.kde.org
Wed Oct 16 13:50:02 BST 2019
sitter created this revision.
Herald added a project: Okular.
Herald added a subscriber: okular-devel.
sitter requested review of this revision.
REVISION SUMMARY
same as in fbeff5ae7c2b27577d829839879b0966b5a3859a <https://phabricator.kde.org/R223:fbeff5ae7c2b27577d829839879b0966b5a3859a> there may not be
a pdfOptionsPage when using print preview.
this fixes an exciting crash on our windows build when trying to print
preview
TEST PLAN
can't easily build on windows but the traceback definitely falls over 0x0000 on that line, so given context I am confident this fixes the crash
REPOSITORY
R223 Okular
BRANCH
Applications/19.08
REVISION DETAIL
https://phabricator.kde.org/D24696
AFFECTED FILES
generators/poppler/generator_pdf.cpp
To: sitter
Cc: okular-devel, johnzh, andisa, siddharthmanthan, maguirre, fbampaloukas, joaonetto, kezik, tfella, ngraham, darcyshen, aacid
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20191016/bbe5af26/attachment.html>
More information about the Okular-devel
mailing list