D25484: Enable closing a tab by middle click

[Nathaniel Graham]

ngraham added a comment.


  In D25484#567112 <https://phabricator.kde.org/D25484#567112>, @bdbai wrote:
  
  > In D25484#566490 <https://phabricator.kde.org/D25484#566490>, @pino wrote:
  >
  > > ...
  > >
  > > In D25484#566483 <https://phabricator.kde.org/D25484#566483>, @romangg wrote:
  > >
  > > > The solution to accidentally clicks is not disabling it by default and making it configurable, but providing the functionality to "restore" a tab after closing it accidentally. Dolphin and Chrome allow me to restore the last closed tab with Ctrl+Shift+T.
  > >
  > >
  > > And this "solution" does not always work, for example when a page was the result of a form submission, redirection, or other kind of interactivity.
  >
  >
  > @ngraham In Okular, when a tab with unsaved changes is about to close, the user will be prompted first. Does this help?
  
  
  Yes this helps the case that @pino brings up, but it handles a different use case. Most of the time a tab won't have unsaved changes because Okular is primarily a reading app. An "Undo last closed tab" feature is for these other cases.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D25484

To: bdbai, #vdg
Cc: aacid, davidhurka, ngraham, romangg, ndavis, pino, okular-devel, johnzh, andisa, siddharthmanthan, maguirre, fbampaloukas, joaonetto, kezik, tfella, darcyshen
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20191125/303df28c/attachment.html>