D21971: Replace ToolAction by ToggleActionMenu

[Simone Gaiarin]

simgunz added a comment.


  In D21971#560810 <https://phabricator.kde.org/D21971#560810>, @davidhurka wrote:
  
  > - Restrict toolbar button popup mode to DelayedPopup and MenuButtonPopup using a custom enum
  >
  >   Honestly, I’m not sure whether this is good. We say no one wants to use InstantPopup, but as well we could say no one wants DelayedPopup. @ngraham?
  
  
  What distinguish `ToggleActionMenu` from `KMenuAction` is that when plugged in a toolbar and an action is checked, that action becomes the default. This functionality makes sense for both MenuButtonPopup and DelayedPopup while it does not for InstantPopup. If one need to use InstantPopup he should not use this class but the others that already provide this functionality.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D21971

To: davidhurka
Cc: ngraham, simgunz, okular-devel, johnzh, andisa, siddharthmanthan, maguirre, fbampaloukas, joaonetto, kezik, tfella, darcyshen, aacid
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20191116/372d4937/attachment-0001.html>