D21971: Replace ToolAction by ToggleActionMenu

Simone Gaiarin noreply at phabricator.kde.org
Wed Nov 6 08:19:19 GMT 2019


simgunz added a comment.


  I also would like to get rid of `DefaultLogic` and just use `ImplicitDefaultAction`, but I am not sure if this creates problem when `ToggleActionMenu` is placed in a menu. Should it behave as a standard `KActionMenu` when in a menu? I think that when in a menu there is no meaning of "default action", because when clicked, the `ToggleActionMenu` should just open the submenu, right?

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D21971

To: davidhurka
Cc: ngraham, simgunz, okular-devel, johnzh, andisa, siddharthmanthan, maguirre, fbampaloukas, joaonetto, kezik, tfella, darcyshen, aacid
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20191106/da564a79/attachment.html>


More information about the Okular-devel mailing list