D10859: Improve layout of annotation configuration dialogs

[Simone Gaiarin]

simgunz marked 3 inline comments as done.
simgunz added a comment.


  Yes I meant the brushes (that behave as the freehand annotation). For me setting it to Width is fine.

INLINE COMMENTS

> ngraham wrote in dlgannotationsbase.ui:55
> Is this change intentional? If so, can we just move the ampersand around so that it still has an accelerator?

Yes.

Both Author and Add had 'a' as accelerator. This was actually working. Pressing 'a' twice switch between the two.

Nonetheless I changed it to make the accelerators unique.

Initially I set 'u' as accelerator for Author but this was conflicting with 'Move Up' and the accelerator of author was automatically changed to 't' once running Okular. (not sure why this did not happen also for 'a').

Then I noticed that not setting the accelerator let Qt set one automatically, so I decided to not set it. Mainly because I though that it make sense to set it only if it has a logical sense like 'u' for Move Up or 'd' for Move Down, but given that 't' is a random letter of author I decided to let it be automatic.

Maybe it is better to set one explicitly?

> davidhurka wrote in annotationwidgets.cpp:378
> Capitalize symbol?

KDE HIG prescribe sentence style capitalization for labels in a form layout: https://hig.kde.org/style/writing/capitalization.html

> davidhurka wrote in annotationwidgets.cpp:379
> Read in the user documentatio that it theoretically works.

Sometimes works. :-) Try with a path to an icon. In any case I'll improve the Stamp tool soon, adding a 'select file' button. I have some code ready that I'll share soon.

REPOSITORY
  R223 Okular

BRANCH
  fix-annot-config-dialog

REVISION DETAIL
  https://phabricator.kde.org/D10859

To: simgunz, #okular, #vdg, ngraham
Cc: davidhurka, aacid, okular-devel, knambiar, ngraham, joaonetto, tfella, darcyshen
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20190531/d58a24a9/attachment-0001.html>