D10859: Improve layout of annotation configuraton dialogs
Nathaniel Graham
noreply at phabricator.kde.org
Tue May 28 15:08:08 BST 2019
ngraham added a comment.
Big improvement. Code looks sane, but I think we can go even further! I don't see the need for a top level grid layout here; we can use a FormLayout for each annotation page's own layout. For any layout where there's a thing on the right that consists of more than one item, you can put them in a QHBoxLayout, and then put that in the FormLayout.
REPOSITORY
R223 Okular
REVISION DETAIL
https://phabricator.kde.org/D10859
To: simgunz, #okular, #vdg, ngraham
Cc: aacid, okular-devel, knambiar, ngraham, joaonetto, tfella, darcyshen
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20190528/4eb26de9/attachment.html>
More information about the Okular-devel
mailing list