D21332: Okular Annotation: add line start/end style config only for Straight Line tool

[Tobias Deiminger]

tobiasdeiminger added inline comments.

INLINE COMMENTS

> knambiar wrote in annotationwidgets.cpp:499
> Is the `nullptr` check really necessary?

No, I'd accept anyways. I just think the implication "object pointer != nullptr" => "object valid" is more obvious to new contributors than "some member == some magic number" => "object valid".

How about adding a `Q_ASSERT`as we did it in `TextAnnotationWidget::applyChanges`? If you go for it, please also initialize members (as done for `TextAnnotationWidget`in `annotationwidgets.h`).

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D21332

To: knambiar, #okular
Cc: tobiasdeiminger, okular-devel, joaonetto, tfella, ngraham, darcyshen, aacid
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20190524/0d0f3f2d/attachment.html>