D21364: Indicate annotation color in annotation list

[Jan Gerrit Marker]

jangmarker added a comment.


  In D21364#469215 <https://phabricator.kde.org/D21364#469215>, @davidhurka wrote:
  
  > In D21364#469159 <https://phabricator.kde.org/D21364#469159>, @jangmarker wrote:
  >
  > > I think `captionForAnnotation()` does not include the comment's text currently, so this change should probably be done in another commit.
  >
  >
  >
  >
  > > It would make sense to show icons to indicate the annotation type, e.g. a different icon for highlight, freehand lines, underlines etc. And if these were colored according to the annotation's color, that would be perfect IMO.
  >
  > That’s what I meant. :)
  
  
  I'm currently investigating whether I can make that work :-) That would be really cool.
  
  > 
  > 
  >> I would personally also like it, if e.g. for "Highlights" of text it Okular could show the actual text which was highlighted.
  > 
  > Makes sense. I. e. instead of showing the comment, because how often does one add a comment to e. g. a squiggle underline?
  > 
  > In D21364#469111 <https://phabricator.kde.org/D21364#469111>, @davidhurka wrote:
  > 
  >> should data() return an "okular" icon by default? If there is no data that can be shown in an icon, the horizontal space could be used for the comment instead.
  > 
  > 
  > Thought about it: the okular icon might make sense. The stamp annotation is the only one which doesn’t use color, and coincidentally stamps an Okular icon. ;) But unfortunately, it //has// a color. What do you get in the tree view if you make some stamps?
  
  With the current code it's just showing the Okular icon as usual, because when I tried the color was invalid.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D21364

To: jangmarker, #okular
Cc: davidhurka, okular-devel, joaonetto, tfella, ngraham, darcyshen, aacid
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20190523/4ebcc2c4/attachment-0001.html>