D21238: Okular Annotation: add support for line start style for Straight Line tool

[Tobias Deiminger]

tobiasdeiminger added inline comments.

INLINE COMMENTS

> annotationwidgets.cpp:556
> +
> +    for (auto i: { i18n( " Square" ), i18n( " Circle" ), i18n( " Diamond" ), i18n( " Open Arrow" ), i18n( " Closed Arrow" ),
> +                    i18n( " None" ), i18n( " Butt" ), i18n( " Right Open Arrow" ), i18n( " Right Closed Arrow" ), i18n( "Slash" ) })

You could say `for ( const QString &i: { /* ... */ } )` here? I think `auto i` adds an unnecessary QString copy constructor call (but negligible because COW and no hot path), and there's no need for auto deduction because the type is simple.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D21238

To: knambiar, #okular
Cc: ngraham, tobiasdeiminger, okular-devel, joaonetto, tfella, darcyshen, aacid
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20190517/c89fbfbb/attachment.html>