D21195: [RFC] Create a Change Colors menu (with toolbar button)

[David Hurka]

davidhurka marked 4 inline comments as done.
davidhurka added a comment.


  The lambda looks much better, but it uses still `int` as action data, not `Okular::SettingsCore::EnumRenderMode::type`, which would make more sense. Is it possible to put `Okular::SettingsCore::EnumRenderMode::type` into the action’s QVariant? It didn’t work because I couldn’t register it as metatype.
  
  As soon as that works, I will submit lambdas for the other menus (see D21196 <https://phabricator.kde.org/D21196>).
  
  I tried to subclass KActionMenu to get the checkbox away. It works almost cleanly, but now QToolButton::showMenu() invents some new menu structures. I will try to understand what’s going on there.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D21195

To: davidhurka, #okular, #vdg
Cc: davidre, aacid, ngraham, okular-devel, joaonetto, tfella, darcyshen
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20190514/c8cb0baf/attachment-0001.html>