D21195: [RFC] Create a Change Colors menu (with toolbar button)

[David Hurka]

davidhurka added a comment.


  In D21195#464938 <https://phabricator.kde.org/D21195#464938>, @aacid wrote:
  
  > That menu is ultra hard to understand, it's a checked action + menu with an action with the same name inside that is also a checked action
  
  
  Maybe the names should be changed. How about:
  
    Color Mode ->
    [_] Enable Color Modification
    (_) Invert Colors
    (_) Change Paper Color
    (_) Change Dark & Light Colors
    (_) Convert to Black & White
  
  The checkbox on the submenu has to be removed, of course. It’s there because the KActionMenu is checkable to make the toolbar button toggle. But with a subclassed KActionMenu, this should be possible.
  
  > Also, why the double && ?
  
  Whoops, didn’t see that. With `&`, they became accelerators. With `&`, I got &.

INLINE COMMENTS

> davidre wrote in pageview.cpp:637
> You could use a lambda instead

That is, I assign a lambda function to a locale `auto` variable, and “call” the variable? (I’m new to lambda, so I will try that.)

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D21195

To: davidhurka, #okular, #vdg
Cc: davidre, aacid, ngraham, okular-devel, joaonetto, tfella, darcyshen
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20190513/1d841c00/attachment.html>