D21136: Fix line annotation leader line angle

[Tobias Deiminger]

tobiasdeiminger created this revision.
Herald added a project: Okular.
Herald added a subscriber: okular-devel.
tobiasdeiminger requested review of this revision.

REVISION SUMMARY
  For "Straight Line" annotations, the "Leader Lines" (if any) shall be perpendicular to the main line segment.
  Current code missed to consider page aspect ratio when calculating the main segment angle, which caused non-perpendicular leader lines.
  
  Note: Bug is only visible with non-PDF documents (i.e. where Okular draws line annotation, instead of generator).

TEST PLAN
  - open a txt file, the generated page will have aspect ratio 3:4
  - configure a "Straight Line" annotation with long leader line
  - create a line annotation at 45 degree angle
  - check the leader line, it shall be perpendicular to the main line

REPOSITORY
  R223 Okular

BRANCH
  fix_leaderline_angle (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21136

AFFECTED FILES
  ui/pagepainter.cpp

To: tobiasdeiminger
Cc: okular-devel, joaonetto, tfella, ngraham, darcyshen, aacid
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20190510/516849b8/attachment.html>