D20760: Okular Annotation: add support for line ending style for Straight Line tool
Tobias Deiminger
noreply at phabricator.kde.org
Thu May 9 10:19:27 BST 2019
tobiasdeiminger added a comment.
> There's a few `#ifdef HAVE_POPPLER_mm_nn` checks in the code, may be we could adapt it for 0.72?
Yes, we can add this to PDF generator code, that's the easy part.
But we can't simply `ifdef` UI code based on properties of a particular generator, because the UI shall be generator agnostic. This means for the UI we need a runtime decision whether to enable the feature. As said, honestly I don't know of a good way how to propagate the information from generator to UI. Maybe Albert has a suggestion.
REPOSITORY
R223 Okular
REVISION DETAIL
https://phabricator.kde.org/D20760
To: knambiar, #okular, #vdg, sander, ngraham
Cc: aacid, pino, sander, davidhurka, tobiasdeiminger, ngraham, okular-devel, joaonetto, tfella, darcyshen
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20190509/0731a579/attachment-0001.html>
More information about the Okular-devel
mailing list