D21069: [RFC] Improve documentation of Document::setPageTextSelection()

[David Hurka]

davidhurka added a comment.


  I suggested this in D18744#441906 <https://phabricator.kde.org/D18744#441906>.
  
  It would be more natural not to delete `rect`, because that causes a dangling pointer, and makes the calling code look memory leaking.
  
  I’m new with submitting patches, so feel free to correct anything.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D21069

To: davidhurka
Cc: okular-devel, joaonetto, tfella, ngraham, darcyshen, aacid
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20190507/e378fb8c/attachment.html>