D20760: Okular Annotation: add support for line ending style for Straight Line tool
Oliver Sander
noreply at phabricator.kde.org
Thu May 2 21:49:11 BST 2019
sander added a comment.
> I'd advocate to implement drawing the lines by code, i.e. QPainter::drawLine and friends. Then reuse the same code to draw icons.
Agreed, but that is too much for a single patch.
Rajeesh, nice patch! Can you get rid of the unicode symbols in the source code using one of the ways Tobias proposed? After that I would say that patch is good and can be applied.
REPOSITORY
R223 Okular
REVISION DETAIL
https://phabricator.kde.org/D20760
To: knambiar, #okular, #vdg
Cc: sander, davidhurka, tobiasdeiminger, ngraham, okular-devel, joaonetto, tfella, darcyshen, aacid
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20190502/6bb3dcf3/attachment.html>
More information about the Okular-devel
mailing list