D20948: [EPubGenerator] Avoid pointless scans of the whole document
Stefan BrĂ¼ns
noreply at phabricator.kde.org
Wed May 1 23:55:56 BST 2019
bruns created this revision.
bruns added a reviewer: Okular.
Herald added a project: Okular.
Herald added a subscriber: okular-devel.
bruns requested review of this revision.
REVISION SUMMARY
The "<video></video>" tag is a placeholder, and should only be processed
when it has been inserted for this toc item, i.e. when movieAnnots is
non-empty. Also place the search cursor at the last inserted block,
otherwise the expression will search from the beginning of the document.
Do likewise for audio/soundActions.
This makes loading large documents much fasters, and even fixes crashing
on huge documents, e.g. from project Gutenberg "The Complete Works of
William Shakespeare" (3200 pages) or the "King James Bible" (1400 pages).
TEST PLAN
open a large EPub file (see above)
REPOSITORY
R223 Okular
REVISION DETAIL
https://phabricator.kde.org/D20948
AFFECTED FILES
generators/epub/converter.cpp
To: bruns, #okular
Cc: okular-devel, joaonetto, tfella, ngraham, darcyshen, aacid
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20190501/c6ef0f73/attachment.html>
More information about the Okular-devel
mailing list