D18358: [WIP] Add buttons to collapse and expand all elements

[Albert Astals Cid]

aacid added a comment.


  Are we waiting for the new icons here? Any idea if they will be ever done or should we just go with something else?

INLINE COMMENTS

> side_reviews.cpp:155
> +    connect(expandAll, &QAction::triggered, this, &Reviews::slotExpandAll);
> +    QAction * collapseAll = toolBar->addAction( QIcon::fromTheme( QStringLiteral("file-zoom-out") ), i18n( "Collapses all elements" ) );
> +    connect(collapseAll, &QAction::triggered, this, &Reviews::slotCollapseAll);

This should probably be Collapse instead of Collapses. Not sure that's very english-y. @ngraham does it sound right to you?

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D18358

To: joaonetto, #okular, #vdg
Cc: aacid, ngraham, okular-devel, tfella, darcyshen
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20190306/b799cfa7/attachment-0001.html>