D22118: Closing the sidebar shifts focus to the document/away from the sidebar.

[Mayank Choudhary]

mayankchoudhary created this revision.
Herald added a project: Okular.
Herald added a subscriber: okular-devel.
mayankchoudhary requested review of this revision.

REVISION SUMMARY
  If we click on a sidebar item to collapse it, the focus remains on the sidebar item list and pressing the up/down arrow, j, k or page up/down key doesn't scroll the document, instead iterates through the sidebar items. Applying this patch, the focus shifts to the document on collapsing the sidebar.
  If the sidebar is collapsed when the document is not opened, the focus shifts away from it.
  
  BUG: 213508

TEST PLAN
  1. Open a PDF document
  2. The sidebar becomes active showing contents or thumbnails
  3. The user doesn't want to see them, so clicks on the sidebar active item to hide the contents/thumbnails pane
  4. To scroll the page, the user presses the up/down arrow, j, k or page up/down key
  5. The sidebar items iterates instead of scrolling of document
  6. Applying this patch, the document should be scrolled in step 4

REPOSITORY
  R223 Okular

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22118

AFFECTED FILES
  part.cpp
  ui/sidebar.cpp
  ui/sidebar.h

To: mayankchoudhary
Cc: okular-devel, fbampaloukas, joaonetto, tfella, ngraham, darcyshen, aacid
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20190627/0ca8a2e0/attachment.html>