D22064: General improvements to stamp annotation

[Simone Gaiarin]

simgunz created this revision.
simgunz added a reviewer: Okular.
Herald added a project: Okular.
Herald added a subscriber: okular-devel.
simgunz requested review of this revision.

REVISION SUMMARY
  Configuration:
  
  - Add push button to select custom stamp image
  - Check if loaded image is usable as stamp or throw error
  - Keep image proportions in previewer
  - Move previewer below the combobox to display larger preview
  
  Annotation tool:
  
  - Keep stamp image proportion in annotation preview (while left mouse button is down)
  - Adding the annotation with one-click (without holding the left mouse button and dragging) adds the stamp with original proportions
  
  TODO:
  
  [ ] Check if filters in file chooser make sense / propose better alternative
  [ ] Update doc

TEST PLAN
  From stamp annotation configuration dialog:
  
  - Click push button next to combo box opens a file selector
  - Selecting a corrupted image file should throw an error
  - Selecting a good image file shows the preview of the image
  - Select a horizontal image shows a large clear preview
  - Select a vertical image file shows a smaller preview without messing up the visual of the config dialog
  
  From page view, select the stamp annotation with horizontal image file (not squared):
  
  - Click and hold. The preview maintains proportions
  - Single click. The stamp image in the pdf maintains proportions and has the same size of the click and hold preview.
  - Add an annotation of the Okular custom stamps (internal SVG so treated slightly differently) do not create problems

REPOSITORY
  R223 Okular

BRANCH
  improve-stamp-annotation

REVISION DETAIL
  https://phabricator.kde.org/D22064

AFFECTED FILES
  ui/annotationwidgets.cpp
  ui/annotationwidgets.h
  ui/guiutils.cpp
  ui/guiutils.h
  ui/pagepainter.cpp
  ui/pageviewannotator.cpp

To: simgunz, #okular
Cc: okular-devel, fbampaloukas, joaonetto, tfella, ngraham, darcyshen, aacid
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20190624/134e8131/attachment.html>