D21755: [RFC] Replace ToolAction by a more universal “ToggleActionMenu”

[David Hurka]

davidhurka added a comment.


  In D21755#482896 <https://phabricator.kde.org/D21755#482896>, @simgunz wrote:
  
  > To be more clear, I think that the code below should provide a default working action menu (basically as it was before, but customizable if necessary):
  >
  >       
  >
  >   d->aMouseModeMenu = new ToggleActionMenu( this );
  >   d->aMouseModeMenu->addAction( d->aMouseSelect );
  >   d->aMouseModeMenu->addAction( d->aMouseTextSelect );
  >   d->aMouseModeMenu->addAction( d->aMouseTableSelect );
  >
  
  
  I just tried to implement MenuLogic with ImplicitDefaultAction mode, and then I decided it’s easiest and straightforward to add suggestDefaultAction(). So it is possible.
  
  It is available in D21971 <https://phabricator.kde.org/D21971>. What do you think about it?

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D21755

To: davidhurka, #okular
Cc: simgunz, aacid, #vdg, okular-devel, fbampaloukas, joaonetto, tfella, ngraham, darcyshen
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20190621/66d6768a/attachment.html>