D15580: New annotation toolbar

[David Hurka]

davidhurka added a comment.


  Don’t have UI feedback that asks for action already in this patch. :)
  
  In D15580#481270 <https://phabricator.kde.org/D15580#481270>, @simgunz wrote:
  
  > F6902170: Screenshot_20190617_165440.png <https://phabricator.kde.org/F6902170>
  
  
  
  
  - Maybe the 4 left buttons should indicate that they require further action (drawing). Currently they look like buttons in a word processor, where you have to select the text first. *1) Using the existing dynamic annotation icons might look better, as soon as someone made them more low-resolution friently.
  
  - The first two separators look a bit like only the first four buttons are annotation tools, and the next 3+2 buttons are just options. I. e. there is not a mutually exclusion between the 4+3+2 buttons, but only between the 4, 3, and 2 individually. Maybe it’s better to group them not with separators, but with ToolActions/ToggleActionMenus. Could be tested later by customizing the toolbar via Configure Toolbars.
  
  *1) Maybe an interesting idea: Select some text in Text Selection mode, then just click the annotation button.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D15580

To: simgunz, #okular
Cc: aacid, anthonyfieroni, davidhurka, knambiar, ngraham, tobiasdeiminger, okular-devel, fbampaloukas, joaonetto, tfella, darcyshen
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20190617/f3c5217b/attachment.html>