D21755: [WIP] Replace ToolAction by a more universal “ToggleActionMenu”

[Simone Gaiarin]

simgunz added a comment.


  In D21755#481293 <https://phabricator.kde.org/D21755#481293>, @davidhurka wrote:
  
  > In D21755#481269 <https://phabricator.kde.org/D21755#481269>, @simgunz wrote:
  >
  > > Currently I am using ToolAction in the new annotation toolbar to selected among different geometrical annotation. [...]
  > >  For this purpose I need that the action are checkable, and that the ToggleActionMenu is checkable displaying the selected action (exaclty as ToolAction).
  > >
  > > [...] For my use case, I would probably need to be able to display tooltips for each action in the ToggleActionMenu, to describe what they are.
  > >
  > > [...] I need to use it for Geometrical annotations and for the Stamp annotation. For this last one I would need to display the different available stamps, so each action in the ToggleActionMenu should just be a checkable action with a full width image and no text. [...]
  >
  >
  > Maybe it’s better to use a KSelectAction directly? Not sure whether it shows the current selection on the toolbar button, but probably it does so in combobox mode.
  >
  > For the stamps, you probably need a combobox with a custom item view.
  
  
  The problem of KSelectAction is that in ComboBoxMode it looks pretty ugly and does not show the checked Action. My guess is that this is the reason why ToolAction was created in the first place.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D21755

To: davidhurka, #okular
Cc: simgunz, aacid, #vdg, okular-devel, fbampaloukas, joaonetto, tfella, ngraham, darcyshen
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20190617/c849d717/attachment-0001.html>