D21734: [WIP] Improve class documentation for PageView and PageViewItem

[David Hurka]

davidhurka added a comment.


  In D21734#478372 <https://phabricator.kde.org/D21734#478372>, @aacid wrote:
  
  > In D21734#477729 <https://phabricator.kde.org/D21734#477729>, @davidhurka wrote:
  >
  > > Oh, does someone know any intended purpose division between setupActions(), setupViewerActions(), and setupBaseActions()?
  >
  >
  > someone does yes.
  >
  > it has to do with part's m_embedMode check part.cpp it's actually pretty easy to see the use case for them
  
  
  I think I figured that out now.
  
  ViewerWidgetMode limits editing actions, and PrintPreviewMode additionally limits zoom action shortcuts. I don’t understand why viewer embedding modes forbid text selection.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D21734

To: davidhurka, #okular
Cc: aacid, okular-devel, joaonetto, tfella, ngraham, darcyshen
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20190612/66c440c4/attachment.html>