D15580: New annotation toolbar

Albert Astals Cid noreply at phabricator.kde.org
Tue Jun 11 23:40:26 BST 2019


aacid added inline comments.

INLINE COMMENTS

> simgunz wrote in pageview.cpp:665
> Anyone knows how KToggleToolBarAction is supposed to work?
> 
> Currently it does nothing.
> 
> Reading the code, it seems that the constructor where the toolbar is specified by name does nothing, unless there is some other magic going on.
> https://api.kde.org/frameworks/kxmlgui/html/ktoggletoolbaraction_8cpp_source.html#l00061

You're right, it seems it never has. Can you use the other one?

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D15580

To: simgunz, #okular
Cc: aacid, anthonyfieroni, davidhurka, knambiar, ngraham, tobiasdeiminger, okular-devel, joaonetto, tfella, darcyshen
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20190611/3f26cd0e/attachment.html>


More information about the Okular-devel mailing list