D21755: Replace ToolAction by a more universal “ToggleActionMenu”

[Albert Astals Cid]

aacid added inline comments.

INLINE COMMENTS

> davidhurka wrote in toggleactionmenu.h:24
> I get a warning in this line “has virtual methods but non-virtual destructor”. True, the default destructor is not virtual, hiding the virtual destructor of the base class. And yes, Okular crashes at closing.
> 
> How do I add a proper destructor whithout breaking the destructor in KActionMenu?

What do you mean "breaking the destructor"?

Destructors are cascaded adding a destructor won't make the parent class destructor not be called anymore.

I don't  see why you should get this wanrning

KActionMenu ends up inheriting from QObject that has a virtual destructor, so you shouldn't be getting that warning at all

Actually i don't get it

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D21755

To: davidhurka, #okular
Cc: aacid, #vdg, okular-devel, joaonetto, tfella, ngraham, darcyshen
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20190611/a3a76cf3/attachment.html>