D21624: In Toolbar's selection mode menu, show "Text Selection" tool by default

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: Okular, VDG.
Herald added a project: Okular.
Herald added a subscriber: okular-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Currently, the Toolbar's selection mode menu shows the rectangular selection mode
  by default, which is not the most useful or commonly used selection mode.
  
  This patch makes the Text Selection tool the one that's shown by default, since that's
  the kind of selection that's the most useful given the sort of document that Okular
  is typically used to view.

TEST PLAN
  - Delete `~/.config/okularrc` and `~/.config/okularpartrc`
  - Open Okular
  - See that the selection mode toolbar button shows Text Selection by default:
  
  F6874497: Text Selection visible by default.png <https://phabricator.kde.org/F6874497>

REPOSITORY
  R223 Okular

BRANCH
  show-text-selection-in-toolbar-menu-by-default (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21624

AFFECTED FILES
  ui/pageview.cpp

To: ngraham, #okular, #vdg
Cc: okular-devel, joaonetto, tfella, ngraham, darcyshen, aacid
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20190606/71d4bac8/attachment.html>