D15580: New annotation toolbar

[David Hurka]

davidhurka added a comment.


  In D15580#473824 <https://phabricator.kde.org/D15580#473824>, @ngraham wrote:
  
  > Sticky-by-default would probably be okay as long as we can make it //very// clear how to un-select the tool. Probably implementing multiple methods would be good (hit esc key, left-click again on the tool, right-click anywhere, etc).
  
  
  
  
  In D15580#473962 <https://phabricator.kde.org/D15580#473962>, @simgunz wrote:
  
  > To sum up, I would:
  >
  > - keep the sticky button to make the feature clearly visible to the user (see bug 358057). As it is now this feature is hard to discover, took me years to figure it exists.
  > - make the tool sticky by default on first installation, then save the state of the sticky button (if a user prefer non-sticky annotation, after unchecking the sticky button he will have it unchecked when he relaunch Okular)
  > - disable annotation on right click anywhere (as current Okular)
  > - disable annotation on left click on [activated] annotation [button] (as current Okular) [ I have sent a patch to Qt to modify QActionGroup, https://codereview.qt-project.org/c/qt/qtbase/+/255770)
  > - disable annotation on Esc (as current Okular)
  
  
  Seems both compatible and is what I consider optimal.
  
  If someone does (not) want sticky, the pin button can be set to the desired state, and then removed together with the shortcut, because it is a normal toolbar now, right?
  
  Or: Why is this still PageViewToolBar? It is not anymore in the PageView?

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D15580

To: simgunz, #okular
Cc: anthonyfieroni, davidhurka, knambiar, ngraham, tobiasdeiminger, okular-devel, joaonetto, tfella, darcyshen, aacid
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20190604/ed21ecbc/attachment.html>