D15580: New annotation toolbar

Nathaniel Graham noreply at phabricator.kde.org
Mon Jun 3 00:17:46 BST 2019


ngraham added a comment.


  getting there!
  
  UI review of the latest version:
  
  - Having the annotation tools on the main toolbar makes it overflow for all but the largest window sizes. How about putting them in a secondary toolbar below the main one that's hidden until the user shows it by clicking on a "Show annotation tools" item on the main toolbar and/or menubar?
  - The Line width dropdown menu button should make the whole button clickable to show the drop-down rather than only the space under the arrow on the right
  - The entries in the Line width dropdown should visually reflect the width of the line. Could these graphics be generated programmatically rather than using icons?
  - Squiggle and Arrow need new icons; please file a bug on Breeze | Icons and request them
  - The `draw-polygon` icon might make it seem like that tool can only draw pentagons, consider using `draw_polyline` or `draw-polygon-star` instead
  - The Color button should actually show the current color rather than a generic icon
  - The Inner color button needs something to show that it exists; right now it just looks like whitespace in the toolbar. It should show its color like the other button, and for "no color", maybe an empty transparent square?
  - Straight Line is mis-named, it's for drawing anything //but// a straight line! :) Should be something like "Freehand line"
  - I can't figure out what Pin Annotation actually does
  - It's not clear to me how to select existing annotations once an annotation tool has been activated; consider maybe adding a "select annotations" tool or mode under the Selection dropdown menu.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D15580

To: simgunz, #okular
Cc: knambiar, ngraham, tobiasdeiminger, okular-devel, joaonetto, tfella, darcyshen, aacid
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20190602/6cd14c47/attachment.html>


More information about the Okular-devel mailing list