D21271: [WIP] Improve documentation of TextEntity stuff

[Albert Astals Cid]

aacid added inline comments.

INLINE COMMENTS

> davidhurka wrote in textpage_p.h:32
> As mentioned somewhere else, the algorithms in these functions are interesting. (Besides they don’t do a good job with vertical text. I hope by writing documentation I will get some understanding what changes could be appropiate.)
> 
> I just didn’t write the documentation yet (Blahblah placeholders), but doxygen won’t compile it if they don’t appear in this header file. Maybe there is some other way to compile it, just tell me which way is better.
> 
> I think that these functions should be private members of TextPagePrivate, because that is where they are used. If I understand PIMPL correctly, that would be no problem for binary compability.

Ah, you're trying to export already existing functions :D

Didn't realize that.

Why do you want to export them? Yes their are interesting, but where would you use them that is not textpage itself?

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D21271

To: davidhurka, #okular
Cc: aacid, yurchor, okular-devel, joaonetto, tfella, ngraham, darcyshen
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20190602/1abed2a5/attachment.html>