D21376: RFC: In annotations list show highlighted text

[David Hurka]

davidhurka added inline comments.

INLINE COMMENTS

> davidhurka wrote in guiutils.cpp:77
> If you use TextPage::textArea( textSelction ), you will get something like (using above source lines as example...):
> 
>   xtSelection(leftTop, rightDown);// TODO this does not seem
> 
> if only seem was highlighted, right?
> That’s because textArea() is this monster function which implements text selection for Text Selection mode.
> 
> Did you try to make a RegularAreaRect from all NormalizedRect from leftTop and rightDown of each Quad, and pass that to text()?

As I learned recently, normalized coordinates are not necessarily normalized in rotation. We will need to test this with rotated view as well. (Or ignore it and then fix it together with Bug 334297.)

> davidhurka wrote in guiutils.cpp:80
> QString::simplified() is more predictable.

Well, it’s probably the same, because of the text reordering in TextPage. :)

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D21376

To: jangmarker, #okular, aacid
Cc: davidhurka, okular-devel, joaonetto, tfella, ngraham, darcyshen, aacid
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20190602/8c21c04d/attachment-0001.html>