D21416: Add icons for line annotation arrow styles to combo box

[Tobias Deiminger]

tobiasdeiminger added a comment.


  In D21416#472774 <https://phabricator.kde.org/D21416#472774>, @davidhurka wrote:
  
  > Not wrong but not important. How often does one change the color theme while chosing a line ending? I could only imagine that the color theme changes automatically based on enviromnent light sensors, for people who work in a vehicle passing many tunnels. But how often does one chose the line ending while entering/leaving a tunnel the same time?
  
  
  Yes:) Played around a bit, looks like many widgets in Okular don't react to a theme change immediately (only after shell restart). So implementing `pageChanged` for arrow icons would make it worse, unless we fixed the surrounding widgets first.
  
  Guess D21416 <https://phabricator.kde.org/D21416> is ready now? If someone presses accept (also on D21248 <https://phabricator.kde.org/D21248>), I'll land it.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D21416

To: tobiasdeiminger, #okular
Cc: davidhurka, knambiar, ngraham, okular-devel, joaonetto, tfella, darcyshen, aacid
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20190601/91b86719/attachment.html>