D15580: [WIP] New annotation toolbar

[Simone Gaiarin]

simgunz updated this revision to Diff 62320.
simgunz added a comment.


  - Check if chosen color is valid before storing it
  - Notify PageViewAnnotator when the color has changed
  - Add missing annotation tools actions
  - Add XML annotation tools and connect corresponding actions
  - Add typewriter annotation tool
  - Set actions groups for all tools and text tools
  - Reimplement setToolsEnabled and setTextToolsEnabled
  - Reimplement setToolsEnabled and setTextToolsEnabled (correct way)
  - Disable code previously used to define annotation toolbar elements
  - Remove unused static constant
  - Revert "New annotation toolbar"
  - Add method to set color picker colorized icon
  - Remove method annotationColor
  - Set color of annotations tools when changed in color picker
  - Read color from settings when annotation tool selected
  - Save annotation tool settings to file on exit
  - Rename and simplify method to deselect all annotation actions
  - Refactor colorChanged slot
  - Add font selector
  - Add methods to access annotation and engine elements
  - Add basic implementation of width selector
  - Minor refactor
  - Remove unused code
  - Store font and width actions
  - Enable config actions based on selected annotation
  - Re-sort code
  - Add arrow annotation
  - Rename variables
  - Add inner color selector
  - Clean setEnabled method
  - Set inner color icon to transparent if tool does not support it
  - Allow setting font color
  - Fix widthAction wrongly enabled for inline-note
  - Fix crash on application exit
  - Improve annotations default colors
  - Fix arrow annotation tool XML
  - Use draw-polyline icon for Polygon
  - Change icon of strikethrough (remove symbolic suffix)
  - Add TODO in code
  - Rename PageViewToolBar to AnnotationActionHandler
  - No need to forceHide mechanism
  - Use KToggleAnnotationToolBar to show/hide toolbar (not working)
  - Remove unused variable
  - Remove tooltips that are never shown in any case
  - Add width action icons
  - Use KToggleAction
  - Make m_toolsDefinition a QDomDocument
  - Remove unused method
  - Refactor code and remove obsolete code
  - Detach annotation when mouse mode is not Normal mode
  - Use Qt5 connect syntax where possible
  - Add Advanced Settings dialog
  - Set better action names
  - Add opacity selection action
  - Fix width text
  - Rename XML actions
  - Keep a state of the selected tool
  - Add favorite annotation tools
  - Correctly enable annotations
  - Fix advanced settings not saved
  - Fix and simplify width action
  - Fix and simplify opacity action
  - Fix annotation tools actions
  - Rename color action
  - Formatting
  - Remove unuseful annotation separators
  - Correctly set favorites action enabled
  - Properly trigger favorite action
  - Allow unchecking annotation actions
  - Minor refactor
  - Save state of continuous mode
  - Clean parseTool
  - Initialize private members
  - Add action to toggle annotation toolbar, set default position below
  - Add i18n
  - Move default value to declaration
  - Add tooltips
  - Fix error in rebase
  - Disable name and type edit for builtin tools
  - Fix action deselected if favorite tool with the same type is activated
  - Fix geom shapes action disabled when okular reparses config
  - Disable text annotation when file does not support them

REPOSITORY
  R223 Okular

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15580?vs=61742&id=62320

BRANCH
  new-annotation-toolbar

REVISION DETAIL
  https://phabricator.kde.org/D15580

AFFECTED FILES
  CMakeLists.txt
  conf/dlgannotations.cpp
  conf/dlgannotationsbase.ui
  conf/editannottooldialog.cpp
  conf/editannottooldialog.h
  conf/okular.kcfg
  part.rc
  shell/shell.cpp
  shell/shell.h
  shell/shell.rc
  ui/annotationactionhandler.cpp
  ui/annotationactionhandler.h
  ui/annotationwidgets.cpp
  ui/annotationwidgets.h
  ui/data/tools.xml
  ui/pageview.cpp
  ui/pageview.h
  ui/pageviewannotator.cpp
  ui/pageviewannotator.h
  ui/pageviewutils.cpp
  ui/pageviewutils.h
  ui/toolaction.cpp

To: simgunz, #okular
Cc: cfeck, aacid, davidhurka, knambiar, ngraham, tobiasdeiminger, okular-devel, maguirre, fbampaloukas, joaonetto, kezik, tfella, darcyshen
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20190722/290db3d1/attachment-0001.html>