D22617: Add icons for pagelayout options, as needed in Okular

[David Hurka]

davidhurka added a comment.


  In D22617#500131 <https://phabricator.kde.org/D22617#500131>, @ndavis wrote:
  
  > I'll give the latest changes a proper review in a little while.
  >
  > In D22617#500046 <https://phabricator.kde.org/D22617#500046>, @davidhurka wrote:
  >
  > > What is the icons-dark directory good for? The icons in there are mostly just the same as in icons.
  >
  >
  > Non-Qt apps, since they don't work with our stylesheets. Hopefully an XDG standard for coloring symbolic/monochrome icons will fix that and then we can drop icons-dark.
  
  
  But it is just a redundancy. Can’t there be a script, which copies icons to icons-dark and changes the colors, when compiling the icons?
  
  >> And I’m a bit concerned that scour-icon removes the id="currentColorScheme" attribute from the stylesheet. How do I avoid that?
  > 
  > Hm, you could try removing `--enable-id-stripping` and `--shorten-ids` from the command. If anything from this page <https://community.kde.org/Guidelines_and_HOWTOs/Icon_Workflow_Tips> confuses you or doesn't work, be sure to post in the Discussion section. Writing documentation isn't a strength of mine, but it's something that has to be done.
  
  Done.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D22617

To: davidhurka, #vdg, ndavis
Cc: #okular, kde-frameworks-devel, ngraham, LeGast00n, sbergeron, michaelh, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20190722/3611daed/attachment.html>