D15347: Modify CloseDialogHelper in parttest

[Tobias Deiminger]

tobiasdeiminger added a comment.


  In D15347#496156 <https://phabricator.kde.org/D15347#496156>, @sander wrote:
  
  > > In bug 409638 it's probably a TabletEnterProximity event instead.
  >
  > That's unlikely, because TabletEnterProximityEvents are a bit special.  From https://doc.qt.io/qt-5/qtabletevent.html :
  >
  > "The [...] TabletEnterProximity and TabletLeaveProximity [...] are only sent to QApplication"
  
  
  Could you put a `qInfo() << *e` in `PageViewAnnotator::routeMouseEvent` while reproducing bug 409638 <https://bugs.kde.org/show_bug.cgi?id=409638>, so that we're sure what kind of events cause the trouble?

INLINE COMMENTS

> aacid wrote in parttest.cpp:65
> i'm a bit unhappy about this bit, is the "Fix race condition in PickPointEngine" supposed to fix this and we'd be able to go back to using click() ?

Don't worry, guess we can simply discard D15347 <https://phabricator.kde.org/D15347> in favor of Olivers change in MR9 <https://invent.kde.org/kde/okular/merge_requests/9/diffs?commit_id=535fc0bb6c9b6b78ab6a952b8a076a5569332427> plus MR13 <https://invent.kde.org/kde/okular/merge_requests/13>.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D15347

To: tobiasdeiminger
Cc: sander, aacid, okular-devel, maguirre, fbampaloukas, joaonetto, kezik, tfella, ngraham, darcyshen
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20190716/8b650502/attachment-0001.html>