D15347: Modify CloseDialogHelper in parttest

[Albert Astals Cid]

aacid added inline comments.

INLINE COMMENTS

> parttest.cpp:65
> +        QPushButton *button = buttonBox->button(m_button);
> +        QMetaObject::invokeMethod(button, "click", Qt::QueuedConnection);
>          m_clicked = true;

i'm a bit unhappy about this bit, is the "Fix race condition in PickPointEngine" supposed to fix this and we'd be able to go back to using click() ?

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D15347

To: tobiasdeiminger
Cc: sander, aacid, okular-devel, maguirre, fbampaloukas, joaonetto, kezik, tfella, ngraham, darcyshen
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20190715/211f1cbf/attachment.html>