D17801: Update Okular developer documentation

[Albert Astals Cid]

aacid added inline comments.

INLINE COMMENTS

> Mainpage.dox:45
>  
> -  \li Portable Document Format (PDF)
> -  \li PostScript

I'd use the original sorting here, "noone" about xps but everyone cares about PDF, so it being on top makes sense

> Mainpage.dox:414
>  \verbatim
> -macro_optional_find_package(Okular)
> +remove_definitions(-DTRANSLATION_DOMAIN="okular")
> +add_definitions(-DTRANSLATION_DOMAIN="okular_markdown")

This changeset is wrong (or at least changes the original intent of the document), your changes are for building in source, while the manual is for people that build out of okular's source

> Mainpage.dox:754
>  
> -static KAboutData createAboutData()
> -{
> -    KAboutData aboutData(...);
> -    // fill the about data
> -    return aboutData;
> -}
> +#include <KAboutData>
> +#include <KLocalizedString>

i guess we don't really need this

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D17801

To: yurchor, #okular
Cc: aacid, ngraham, okular-devel, tfella, darcyshen
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20190126/7bea0cf9/attachment.html>