D18399: Fix launching Okular by opening a document from the file browser

Volker Krause noreply at phabricator.kde.org
Sat Jan 19 21:25:56 GMT 2019


vkrause created this revision.
Herald added a project: Okular.
Herald added a subscriber: okular-devel.
vkrause requested review of this revision.

REVISION SUMMARY
  There's two issues here:
  
  - Activity::onCreate triggered before the C++ side was loaded, so the call to C++ failed (causing a crash). So delay that until we are ready.
  - The static instance of URIHandler in the header caused it to duplicate into each translation unit, causing main.cpp to not see what android.cpp wrote into it.

REPOSITORY
  R223 Okular

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18399

AFFECTED FILES
  mobile/android/src/OpenFileActivity.java
  mobile/app/android.cpp
  mobile/app/android.h
  mobile/app/main.cpp

To: vkrause
Cc: okular-devel, tfella, ngraham, darcyshen, aacid
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20190119/9b5819a1/attachment.html>


More information about the Okular-devel mailing list