D18179: PDF: Implement scaling for non-rasterized printing

[Albert Astals Cid]

aacid added a comment.


  We would need a @since marker for the enum and for the new methods and a 
  // TODO merge with function above when a BIC change happens somehwere else
  would also make sense

INLINE COMMENTS

> fileprinter.h:58
> +     */
> +    enum ScaleMode { FitToPrintArea, None };
> +

if this is going to be flags, it should be like this

enum ScaleMode { 
None = 0,
FitToPrintArea = 1
 };

so the next flags can be 2, 4, 8, etc, meaning you can use binary or and binary and on them and it'll all work

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D18179

To: michaelweghorn, #okular, ngraham, sander
Cc: aacid, fvogt, okular-devel, tfella, ngraham, darcyshen
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20190115/e4bad988/attachment.html>