D18179: PDF: Implement scaling for non-rasterized printing

Michael Weghorn noreply at phabricator.kde.org
Fri Jan 11 10:32:42 GMT 2019


michaelweghorn created this revision.
michaelweghorn added reviewers: Okular, ngraham, sander.
Herald added a project: Okular.
michaelweghorn requested review of this revision.

REVISION SUMMARY
  This extends 'FilePrinter::printFile' by an optional
  parameter to specify whether or not to do scaling and passes
  the 'fit-to-page' to CUPS dependent on what is specified.
  If the parameter is not specified, the behaviour remains
  unchanged.
  
  If FilePrinter is used, The PDF generator now passes this
  option depending on the scaling mode was selected in the
  custom print options widget, which is therefore now enabled
  for non-rasterized printing as well.

TEST PLAN
  1. open a PDF document in Okular and open the print dialog
  2. go to the "PDF Options" tab
  3. verify that "Force rasterisation" is disabled, but the "Scale mode" combobox is active.
  4. test all the three options available in the "Scale mode" combobox do what they say
  5. Make sure the three options still work as expected for the "Force rasterisation" case.

REPOSITORY
  R223 Okular

BRANCH
  michaelweghorn/WIP_allowScaledPrintingWithoutRasterization

REVISION DETAIL
  https://phabricator.kde.org/D18179

AFFECTED FILES
  core/fileprinter.cpp
  core/fileprinter.h
  generators/poppler/generator_pdf.cpp

To: michaelweghorn, #okular, ngraham, sander
Cc: okular-devel, ngraham, darcyshen, aacid
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20190111/f648d572/attachment.html>


More information about the Okular-devel mailing list