D18144: Implemented find function from console

Yuri Chornoivan noreply at phabricator.kde.org
Thu Jan 10 16:09:48 GMT 2019


yurchor added a comment.


  In D18144#390624 <https://phabricator.kde.org/D18144#390624>, @joaonetto wrote:
  
  > Tried that, not possible, it gets me compilation error.
  
  
  Ooops... Sorry.
  
  Otherwise, I can confirm that the patch works as expected.

INLINE COMMENTS

> part.cpp:1730
> +    }
> +    
>      return openOk;

Trailing spaces

> shellutils.cpp:62
>      }
> +    
> +    if( !findText.isEmpty() )

Trailing spaces.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D18144

To: joaonetto, #okular
Cc: yurchor, okular-devel, ngraham, darcyshen, aacid
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20190110/6121add4/attachment.html>


More information about the Okular-devel mailing list