D18744: Add action in Edit menu to select the text on current page

[Shubham]

shubham added a comment.


  In D18744#419287 <https://phabricator.kde.org/D18744#419287>, @yurchor wrote:
  
  > In D18744#419212 <https://phabricator.kde.org/D18744#419212>, @shubham wrote:
  >
  > > @yurchor what about the crash case, is it fixed now?
  >
  >
  > No. I think that the action should be created in part.cpp, setEnabled(false) by default, then setEnabled(true) in the Part::openFile to avoid the crash.
  >
  > Regretfully, no function (like isOpened) for setEnabled to connect to.
  
  
  Another strategy can be to check for if doc is not opened and then setEnable(false)
  Since setEnabled() is true by default, my if statement is basically dead code.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D18744

To: shubham, aacid, #vdg, ngraham
Cc: yurchor, michaelweghorn, kde-doc-english, davidhurka, abetts, loh.tar, alexde, ngraham, okular-devel, gennad, tfella, skadinna, darcyshen, aacid
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20190226/8c72d2ac/attachment-0001.html>