D18744: Add action in Edit menu to select the text on current page

[Yuri Chornoivan]

yurchor added a comment.


  Tested. Works as expected.

INLINE COMMENTS

> index.docbook:1296
> +			</variablelist>
> +                        
>  			<variablelist>

Trailing spaces

> pageview.cpp:737
>      kredo->setEnabled(false);
> +    
> +    // Setup select all action for the current page

Trailing spaces

> pageview.cpp:743
> +    addAction( selectCurrentPage );
> +    
> +    if ( d->document->isOpened() ) 

Trailing spaces

> pageview.cpp:5586
> +{
> +    // The code below selects the entire page and copies the text to a clipboard if mode is Text Select 
> +    textSelectionClear();

Trailing space

> pageview.cpp:5590
> +    PageViewItem *item = d->items.at( currentPage );
> +    
> +    if (item)

Trailing spaces

> pageview.cpp:5592
> +    if (item)
> +    {    
> +        Okular::RegularAreaRect * area = textSelectionForItem( item );

Trailing spaces

> pageview.cpp:5598
> +
> +        if ( d->document->isAllowed( Okular::AllowCopy ) ) 
> +        {

Trailing space

> pageview.cpp:5601
> +            if ( !text.isEmpty() ) 
> +            {    
> +                QClipboard *cb = QApplication::clipboard();

Trailing spaces

> pageview.cpp:5607
> +                }
> +                
> +            }

Trailing spaces

> pageview.h:281
>          void slotFitWindowToPage();
> +        
> +        void slotSelectPage();

Trailing spaces

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D18744

To: shubham, aacid, #vdg, ngraham
Cc: yurchor, michaelweghorn, kde-doc-english, davidhurka, abetts, loh.tar, alexde, ngraham, okular-devel, gennad, tfella, skadinna, darcyshen, aacid
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20190225/52e0a628/attachment-0001.html>