D18744: Add action in Edit menu to select the text on current page
Nathaniel Graham
noreply at phabricator.kde.org
Thu Feb 21 20:43:25 GMT 2019
ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.
All right, let's do this. In final testing, I just found some blockers:
- If the current mouseMode is not `TextSelect`, then the menu item is enabled but does nothing. It should do its thing no matter what the mouseMode is, just like Select all does.
- The menu item is still enabled when Okular is opened without a document, and clicking on it crashes Okular. It needs to be disabled when no document is open.
REPOSITORY
R223 Okular
REVISION DETAIL
https://phabricator.kde.org/D18744
To: shubham, aacid, #vdg, ngraham
Cc: michaelweghorn, kde-doc-english, davidhurka, abetts, loh.tar, alexde, ngraham, okular-devel, gennad, tfella, skadinna, darcyshen, aacid
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20190221/ba8b9791/attachment.html>
More information about the Okular-devel
mailing list