D18144: Implemented find function from console

[Albert Astals Cid]

aacid added a comment.


  Do you think you could create an autotest for this? If not it's fine, but would make sure things don't break in the future.

INLINE COMMENTS

> shell.cpp:684
>      KDocumentViewer* const doc = qobject_cast<KDocumentViewer*>(part);
> +    const QString find(QByteArray::fromBase64(ShellUtils::find(serializedOptions).toLatin1()));
>      if ( ShellUtils::startInPresentation(serializedOptions) )

the fromBase64 should be in ShellUtils itself, the serialization/unserialization is what that "class" does, should not leak outside.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D18144

To: joaonetto, #okular
Cc: ngraham, aacid, yurchor, okular-devel, tfella, darcyshen
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20190206/a6c955be/attachment-0001.html>