D18744: Select entire page on mouse double click event

loh tar noreply at phabricator.kde.org
Tue Feb 5 16:22:57 GMT 2019


loh.tar added a comment.


  I suggest:
  
  - Add a new action "Select Page" similar to "Select All"
  - Call first that new action/function, then the copy function, instead of coding explicit in mouse event
  - Shorten your comments, don't say what is obviously, explain things which may indistinct e.g."select the word which was clicked on" "select the entire page if click event is in empty portion"

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D18744

To: shubham, aacid, #vdg
Cc: loh.tar, alexde, ngraham, okular-devel, tfella, darcyshen, aacid
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20190205/81064b24/attachment-0001.html>


More information about the Okular-devel mailing list