D18658: Modify search bar in the contextDrawer

[Carl Schwan]

ognarb added a comment.


  > The search field shouldn't be touching the line below it; it should have as much padding on top as on bottom. Just needs to be vertically centered in its parent, probably.
  
  Ok I will change that :)
  
  > Also, instead of manufacturing your own search field, how about contributing it upstream to Kirigami? There are a number of other places where a QML-yet-non-PlasmaComponents-using desktop app (e.g. System Settings) needs a search field with a clear button.
  
  Just submitted a diff to review: D18716 <https://phabricator.kde.org/D18716>. Thanks for the suggestion.

REPOSITORY
  R223 Okular

REVISION DETAIL
  https://phabricator.kde.org/D18658

To: ognarb, #okular, ngraham
Cc: ngraham, okular-devel, tfella, darcyshen, aacid
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20190203/f7e4f700/attachment.html>