D21971: Replace ToolAction by ToggleActionMenu
Simone Gaiarin
noreply at phabricator.kde.org
Sun Dec 15 09:58:39 GMT 2019
simgunz added a comment.
It does not compile indeed. My fault in the review process, I missed the last commit. I have added the inline comments to fix the bug.
INLINE COMMENTS
> pageview.cpp:660
> + d->aMouseModeMenu = new ToggleActionMenu( QIcon(),QString(), this,
> + QToolButton::MenuButtonPopup,
> + ToggleActionMenu::ImplicitDefaultAction );
Replace `QToolButton::MenuButtonPopup` with `ToggleActionMenu::MenuButtonPopup`.
> toggleactionmenu.h:66
> + MenuButtonPopup
> + }
> +
Missing semicolon after enum declaration
REPOSITORY
R223 Okular
BRANCH
create-configurable-toggleactionmenu
REVISION DETAIL
https://phabricator.kde.org/D21971
To: davidhurka, simgunz
Cc: aacid, ngraham, simgunz, okular-devel, johnzh, andisa, siddharthmanthan, maguirre, fbampaloukas, joaonetto, kezik, tfella, darcyshen
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20191215/aa88919b/attachment-0001.html>
More information about the Okular-devel
mailing list