D25684: [core/*] replace foreach, deprecated, with range-for

[Ahmad Samir]

ahmadsamir updated this revision to Diff 70874.
ahmadsamir marked 7 inline comments as done.
ahmadsamir added a comment.


  ::distanceSqr() is going to be made const, so qAsConst isn't needed
  It's cheaper to copy basic types than reference them
  qAsConst isn't needed when iterating over member variable containers in const methods

REPOSITORY
  R223 Okular

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25684?vs=70756&id=70874

BRANCH
  l-foreach (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25684

AFFECTED FILES
  core/annotations.cpp
  core/bookmarkmanager.cpp
  core/document.cpp
  core/documentcommands.cpp
  core/form.cpp
  core/generator_p.cpp
  core/page.cpp
  core/textdocumentgenerator.cpp
  core/textpage.cpp

To: ahmadsamir, aacid
Cc: okular-devel, johnzh, andisa, siddharthmanthan, maguirre, fbampaloukas, joaonetto, kezik, tfella, ngraham, darcyshen, aacid
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20191204/3a15cb34/attachment.html>