D23164: Improve testPrintD
Adriaan de Groot
noreply at phabricator.kde.org
Thu Aug 15 01:09:03 BST 2019
adridg created this revision.
Herald added a project: Okular.
Herald added a subscriber: okular-devel.
adridg requested review of this revision.
REVISION SUMMARY
- swap out manual management for a PrintDHelper class that allocates an action and MessageBoxHelper, runs the script, and checks the result.
- use _data() to run the helper with different data; this improves observability as well.
TEST PLAN
- Run tests, see same results as before
REPOSITORY
R223 Okular
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D23164
AFFECTED FILES
autotests/kjsfunctionstest.cpp
To: adridg
Cc: okular-devel, maguirre, fbampaloukas, joaonetto, kezik, tfella, ngraham, darcyshen, aacid
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/okular-devel/attachments/20190815/01161674/attachment.html>
More information about the Okular-devel
mailing list